-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Grinding: add materials #2735
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tyrosine1153
commented
Aug 6, 2024
•
edited
Loading
edited
- resolve Update Grinding: add materials #2688
- To do
- Check material rewards in GrindingTest
- Fill test cases in CalculateMaterialReward test code
ipdae
requested changes
Aug 7, 2024
tyrosine1153
force-pushed
the
feature/grind-reward
branch
from
August 7, 2024 10:00
40ceb98
to
bcb86bc
Compare
// Todo : Fill more test cases
tyrosine1153
force-pushed
the
feature/grind-reward
branch
from
August 8, 2024 09:31
0a3f52f
to
7a5cd59
Compare
사후리뷰로 머지합니다 |
ipdae
reviewed
Aug 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.