Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RuneStatModifier생성에 인자로 사용하는 값 통일 (stat.BaseValue, stat.TotalValue) #2650

Open
tyrosine1153 opened this issue Jun 26, 2024 · 0 comments
Milestone

Comments

@tyrosine1153
Copy link
Contributor

          > What's the difference between TotalValue and BaseValue? Should we apply rune level bonus to BaseValue, not TotalValue?

I referred to ChracterStats.cs in Lib9c for client stats ui.
...However, seeing that ArenaCharacter.cs in Lib9c uses TotalValue for SetRuneStats, I think the two values are mixed.
Maybe we should check about these.

Originally posted by @tyrosine1153 in planetarium/NineChronicles#5192 (comment)

룬 연산과 관련해 BaseValue, TotalValue를 혼용하고 있는 부분을 TotalValue로 통일합니다.

@tyrosine1153 tyrosine1153 changed the title > What's the difference between TotalValue and BaseValue? Should we apply rune level bonus to BaseValue, not TotalValue? RuneStatModifier생성에 인자로 사용하는 값 통일 (stat.BaseValue, stat.TotalValue) Jun 26, 2024
@tyrosine1153 tyrosine1153 added this to the v200.0.0 milestone Jun 26, 2024
@Namyujeong Namyujeong modified the milestones: v200.0.0, v220.0.0 Jul 22, 2024
@ipdae ipdae modified the milestones: v220.0.0, v230.0.0 Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

3 participants