Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selectable keystore path #1680

Open
Atralupus opened this issue Jul 21, 2022 · 2 comments
Open

Selectable keystore path #1680

Atralupus opened this issue Jul 21, 2022 · 2 comments
Labels
enhancement New feature or request suggestion upstream The issue caused by some upstream packages.

Comments

@Atralupus
Copy link
Member

Users who play games on multiple devices or care about security, will want to play with a private key in USB.
Especially if they bought a lot of NCG, they will use USB more
I hope the option is added so that the launcher can modify the keystore path
I tried to fix on the v2 launcher, but the UI didn't come out pretty because the settings window was a little narrow.
If you proceed, you may need to add a scroll to the settings window.
I'd be so so so happy if there were additional functions😆

@BasixKOR
Copy link
Contributor

This feature requires the headless and game to allow customized keystore path, thus blocked by upstream.

@BasixKOR BasixKOR added upstream The issue caused by some upstream packages. enhancement New feature or request suggestion labels Jul 21, 2022
@dahlia
Copy link
Contributor

dahlia commented Jul 25, 2022

AFAIK the headless currently uses Web3KeyStore.DefaultKeyStore which sees the system default path ($HOME/.config/planetarium/keystore or %AppData%\planetarium\keystore). In order to specify a different key store path, the headless need to instantiate its own Web3KeyStore object using the constructor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request suggestion upstream The issue caused by some upstream packages.
Projects
None yet
Development

No branches or pull requests

3 participants