Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue: Migration to React 18 #1480

Open
4 tasks
BasixKOR opened this issue Jun 2, 2022 · 1 comment
Open
4 tasks

Tracking issue: Migration to React 18 #1480

BasixKOR opened this issue Jun 2, 2022 · 1 comment
Labels
dependencies Pull requests that update a dependency file help wanted Extra attention is needed upstream The issue caused by some upstream packages.

Comments

@BasixKOR
Copy link
Contributor

BasixKOR commented Jun 2, 2022

Prerequisites

  • Get rid of react-router v5, or migrate to v6
    • V2 interface (should be migrated)
    • V1 interface (should be removed)
    • Monster Collection V1 (should be removed)
    • Transfer uses own routing implementation.

Steps

  • Bump packages to React 18 compatible ones
  • Try concurrent features on some parts that needs it
    • I'm planning to use useDeferredValue on tip indicator, since it causes a ton of UI updates.
@BasixKOR BasixKOR added enhancement New feature or request help wanted Extra attention is needed upstream The issue caused by some upstream packages. labels Jun 2, 2022
@BasixKOR
Copy link
Contributor Author

BasixKOR commented Jun 2, 2022

I expect that using the concurrent features on certain parts of the launcher could improve the perceived performance quite a lot. We need to figure out which components are causing frequent updates first though.

@Akamig Akamig added dependencies Pull requests that update a dependency file and removed enhancement New feature or request labels Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file help wanted Extra attention is needed upstream The issue caused by some upstream packages.
Projects
None yet
Development

No branches or pull requests

2 participants