Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove polling queries #1083

Open
ipdae opened this issue Dec 3, 2021 · 3 comments
Open

Remove polling queries #1083

ipdae opened this issue Dec 3, 2021 · 3 comments
Assignees
@ipdae
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@ipdae
Copy link
Member

ipdae commented Dec 3, 2021 •
edited
Loading

launcher poll some queries for user information (like current block index, monster collection, avatar state).
but it may occur overloading headless because call BlockChain.GetState inside query execution.
@ipdae ipdae added enhancement New feature or request help wanted Extra attention is needed labels Dec 3, 2021
@ipdae
Copy link
Member Author

ipdae commented Dec 3, 2021

here is a list of polling queries I found current head.
image

@BasixKOR
Copy link
Contributor

BasixKOR commented Dec 3, 2021

We could try refactoring them into subscriptions. Although it isn't very straight process (I'm guessing here) and requires some changes to the headless we could reuse the WebSocket connection we already have.

@ipdae ipdae self-assigned this Dec 3, 2021
This was referenced Dec 3, 2021
Merged
Merged
@BasixKOR
Copy link
Contributor

BasixKOR commented Dec 7, 2021

I just noticed that the activation query runs just like polling. It essentially uses sleep instead of pollInterval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ipdae ipdae

Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ipdae @BasixKOR