Review the configuration template file

[jonasraoni]

Describe the bug
The configuration across the applications shares most of the settings, but some of them seems to be missing a synchronization, e.g.:

The config of OMP has:
scheduled_tasks_report_error_only = On

The config of OJS has:
show_upgrade_warning = On
citation_checking_max_processes = 3
sitewide_privacy_statement = Off
:

It's needed to compare the settings across OJS/OMP/OPS for main and stable-3_3_0, and ensure the differences make sense.

Some settings seems to be not used:
[general].citation_checking_max_processes
[files].filename_revision_match
[curl].cainfo

What application are you using?
*/main
*/stable-3_3_0

[kaitlinnewson]

PRs for 3.3 branches ready for review @asmecher:

• OJS: pkp/pkp-lib#8543 sync config templates across applications ojs#4418
• OMP: pkp/pkp-lib#8543 sync config templates across applications omp#1687
• OPS: pkp/pkp-lib#8543 sync config templates across applications ops#760

3.4:

• OJS: pkp/pkp-lib#8543 sync config templates and remove unused values ojs#4519
• OMP: pkp/pkp-lib#8543 sync config templates and remove unused values omp#1758
• OPS: pkp/pkp-lib#8543 sync config templates and remove unused values ops#809

main:

• OJS: pkp/pkp-lib#8543 sync config templates and remove unused values ojs#4528
• OMP: pkp/pkp-lib#8543 sync config templates and remove unused values omp#1769
• OPS: pkp/pkp-lib#8543 sync config templates and remove unused values ops#813

[touhidurabir]

Hi @kaitlinnewson as you are working on this issue , please consider updating the description of validation_timeout under email section . Basically validation_timeout description set as Maximum number of days before an unvalidated account expires and is deleted but in real , it just define time in number of days the validity of validation link in email . The current description of email --> validation_timeout is conflicting and confused with general --> user_validation_period . More details at #10351 .

[kaitlinnewson]

Hi @touhidurabir, I've improved the messaging for validation_timeout in my current PRs to 3.3, and will take a look at user_validation_period when I am porting to 3.4/main.

[kaitlinnewson]

@asmecher the PRs above have been updated and are ready for review.

[kaitlinnewson]

Hi @asmecher, would you have time to give this a look? I'd like to work on this for 3.4/main as well if everything looks good here.

[asmecher]

All 3 stable-3_3_0 PRs merged, thanks! Please go ahead with the other branches.

[kaitlinnewson]

@asmecher other branch PRs are now done (listed above) and ready for review.

[asmecher]

All merged, thanks!