Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression when checking out repositories for a pull request #41

Open
jonasraoni opened this issue May 29, 2024 · 0 comments
Open

Regression when checking out repositories for a pull request #41

jonasraoni opened this issue May 29, 2024 · 0 comments
Assignees

Comments

@jonasraoni
Copy link

The checkout_user_repo.sh has regressions when compared to the startSubmodulesTRAVIS.sh

  1. It's limited to the pkp-lib, but it should cover all submodules
  2. It can't process long branches (e.g. feature/stable-3_4_0/1234-fix-issue)

As part of this task, I think we should try to drop the ##user/repo##" syntax, and do the checkout automatically (if we don't have the right commit in the PKP repository, then check if the user/submodule has what we need).

@withanage withanage self-assigned this Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants