Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

need to sanitize +brewing from more locations #317

Open
jhheider opened this issue Mar 6, 2024 · 1 comment
Open

need to sanitize +brewing from more locations #317

jhheider opened this issue Mar 6, 2024 · 1 comment

Comments

@jhheider
Copy link
Contributor

jhheider commented Mar 6, 2024

things currently in the pantry (may be solved already):

.cmake files:

    - run: sed -i
        -e "s:{{ pkgx.prefix }}:\$\{CMAKE_CURRENT_LIST_DIR\}/../../../../..:g"
        -e "s/\+brewing//g"
        abslTargets{,-release}.cmake
      working-directory: '{{prefix}}/lib/cmake/absl'

.pc files:

    # FIXME: this is a hack; we need to fix fixup.ts
    - run: sed -i 's/\+brewing//g' *.pc
      working-directory: '{{prefix}}/lib/pkgconfig'

possible contender:

    # the make file uses sed over the bindir, our +brewing messes that up.
    - TMP_PREFIX=$(mktemp -d)

.la files going in now for graphviz.org to solve:

/opt/gnu.org/sed/v4.9.0/bin/sed: can't read /opt/graphviz.org/v10.0.1+brewing/lib/libxdot.la: No such file or directory
@mxcl
Copy link
Member

mxcl commented Mar 9, 2024

+brewing is broken at some level and needs revisiting. In general it should be transparent:

  • any bug is either exposing general relocatability issues; or
  • should be transparent since at any point during builds it is just {{prefix}}

The fact it seems to otherwise surface to build scripts suggests some issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants