Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better errors if distributable.url returns a bad content type #28

Open
ddobrinskiy opened this issue Mar 6, 2023 · 5 comments
Open

Comments

@ddobrinskiy
Copy link

@mxcl something looks broken in handling the versions, see last part of semver

image

source code to reproduce: pkgxdev/pantry@6d4cd3f

@ddobrinskiy
Copy link
Author

oops! my bad, just a malformed URL on my part

Still, it's a bit weird how that is displayed in logs

@mxcl
Copy link
Member

mxcl commented Mar 6, 2023

Yeah this is a bug in our curl handling, reopening.

@mxcl mxcl reopened this Mar 6, 2023
@mxcl
Copy link
Member

mxcl commented Mar 6, 2023

Yeah actually I cannot figure out why it doesn’t error cleanly. Is is possible the URL you downloaded returns a HTTP 200 even though it didn’t actually provide a tarball?

@ddobrinskiy
Copy link
Author

@mxcl yes, it indeed returned 200

https://github.com/quarto-dev/quarto-cli/releases/tag/v1.3.242

@mxcl
Copy link
Member

mxcl commented Mar 6, 2023

right, content type is HTML.

We could probs figure this out and give a better error. Will leave open until we do that.

@mxcl mxcl transferred this issue from pkgxdev/pkgx Mar 6, 2023
@mxcl mxcl changed the title brewkit broken {{version}} better errors if distributable.url returns a bad content type Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants