onPageContentSave deletes the file freshly generated by renderUML

[TimoKunze]

After upgrading to a faster server we did run into a strange issue that did cost us quite some time to find the reason.

On the old server renderUML always has been slow enough so that onPageContentSave (which seems to run in parallel) completed before renderUML created the image file. On the new server renderUML completes very fast, so that onPageContentSave finds the freshly created image file and deletes it. The result is that the UML diagram won't show up in the wiki article.

For now we managed to solve this by calling the cleanup function from within renderUML (before writing the new file obviously) and call the cleanup function from onPageContentSave only if the page content does not include any <uml> tag.

This does not seem like a proper fix, so maybe you want to provide a better solution.

We are using Mediawiki 1.34.0 by the way.

[WolfgangFahl]

@TimoKunze thx for reporting. There might be a redesign for the picture handling soon anyways. One proposal is https://www.mediawiki.org/wiki/Extension:Diagrams

[TimoKunze]

@WolfgangFahl Thank you. The extension site states

It replaces the GraphViz and PlantUML extensions in some ways, but does not support all features of either of them

Do you have any knowledge about the missing features compared to PlantUML?

[WolfgangFahl]

@TimoKunze - sure you can try things out at http://diagrams.bitplan.com/ and join the discussion at https://gitter.im/diagrams-service/community. Examples are samwilson/diagrams-service#6 and samwilson/diagrams-extension#9