Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PlantUML is incompatible with image authentication #19

Open
cotto opened this issue Mar 10, 2017 · 1 comment
Open

PlantUML is incompatible with image authentication #19

cotto opened this issue Mar 10, 2017 · 1 comment

Comments

@cotto
Copy link

cotto commented Mar 10, 2017

When Extension:PlantUML detects that plantuml.jar has created an image, it doesn't create the proper database entries for that file. This means that if someone is attempting to use PlantUML from a wiki where image authentication is enabled, img_auth.php will see a request for a file that's not listed in the image table and will return a 404.

The code looks like it's a pain to implement but Extension:GraphViz seems to get it right and is licensed under the same terms as this extension. Extension:PlantUML might even be able to use GraphViz::uploadImages() directly though I haven't tested this.

I'd love to be able to deploy this extension. If I don't have time to come up with a fix, I will at least commit to testing potential fixes.

@samwilson
Copy link

I'm experimenting with working around this by using an external (to MediaWiki) service to render and serve the images: https://www.mediawiki.org/wiki/Extension:Diagrams

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants