Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary stuff from the code #2942

Merged
merged 3 commits into from
Sep 21, 2024
Merged

Remove unnecessary stuff from the code #2942

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
15904ff
removed unused variable
bluepilledgreat Sep 21, 2024
2c3a4b4
remove unused value in activity watcher
bluepilledgreat Sep 21, 2024
7e8b699
remove unnecessary directory check
bluepilledgreat Sep 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions Bloxstrap/Bootstrapper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -753,8 +753,7 @@ private async Task ApplyModifications()

List<string> modFolderFiles = new();

if (!Directory.Exists(Paths.Modifications))
Directory.CreateDirectory(Paths.Modifications);
Directory.CreateDirectory(Paths.Modifications);

// check custom font mod
// instead of replacing the fonts themselves, we'll just alter the font family manifests
Expand Down
1 change: 0 additions & 1 deletion Bloxstrap/Integrations/ActivityWatcher.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ public class ActivityWatcher : IDisposable
public event EventHandler? OnAppClose;
public event EventHandler<Message>? OnRPCMessage;

private readonly Dictionary<string, string> GeolocationCache = new();
private DateTime LastRPCRequest;

public string LogLocation = null!;
Expand Down
1 change: 0 additions & 1 deletion Bloxstrap/Utilities.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ public static VersionComparison CompareVersions(string versionStr1, string versi

public static string GetRobloxVersion(bool studio)
{
string versionGuid = studio ? App.State.Prop.Studio.VersionGuid : App.State.Prop.Player.VersionGuid;
string fileName = studio ? "Studio/RobloxStudioBeta.exe" : "Player/RobloxPlayerBeta.exe";

string playerLocation = Path.Combine(Paths.Roblox, fileName);
Expand Down