Use JCS_ALPHA_EXTENSIONS to detect JCS_EXT_RGBA support #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having trouble trying to use
DecodeIntoRGBAon OS X with libjpeg-turbo installed and it was also failing on a Docker alpine install as well. Looking into things further it appears to be also skipping support for that in the unit tests rather than just for libjpeg and you will see the same thing with the output shown in #18The travis builds also show this being incorrectly skipped, e.g. https://travis-ci.org/pixiv/go-libjpeg/jobs/129381454 has
jpeg_test.go:131: This build is not support DecodeIntoRGBA.even for the libjpeg-turbo run.I believe the problem is in the
getJCS_EXT_RGBAfunction trying to check if an enum has been defined, returning it if it is, but it always returns 0 so any tests based on it fail. I changed it to use theJCS_ALPHA_EXTENSIONSdefinition which I believe is for this purpose and it works as expected.