Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setSkin method is not exposed in ISkeleton interface #526

Open
GregVGW opened this issue Oct 25, 2023 · 0 comments · May be fixed by #527
Open

setSkin method is not exposed in ISkeleton interface #526

GregVGW opened this issue Oct 25, 2023 · 0 comments · May be fixed by #527

Comments

@GregVGW
Copy link

GregVGW commented Oct 25, 2023

The example on changing skins recommends calling setSkin(null) before calling setSkinByName, which is working for us.

However, the setSkin method is not exposed from the ISkeleton interface, requiring us to cast spine.skeleton to any in order for TypeScript to build.

I've taken a look and all the runtimes do have the setSkin method within the Skeleton class, so this seems like a reasonable change to make.

image image

More than happy to create a PR for this if the change seems good.
@GregVGW GregVGW linked a pull request Oct 25, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add setSkin method to ISkeleton interface GregVGW/pixi-spine
1 participant
@GregVGW