Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Receive tabId-only messages on runtime pages #86

Open
1 task
fregante opened this issue Sep 3, 2022 · 1 comment
Open
1 task

Receive tabId-only messages on runtime pages #86

fregante opened this issue Sep 3, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@fregante
Copy link
Collaborator

fregante commented Sep 3, 2022

Reported in pixiebrix/pixiebrix-extension#4208 (comment)


Currently, the only way to message chrome-extension:// pages is by specifying a page, with an optional tabId. If a page is missing, it's assumes that a message is supposed to be forwarded:

if (!to.page) {
return "forward";
}

Improvement

  • Don't assume that a page-less target must be forwarded

Related

@fregante
Copy link
Collaborator Author

fregante commented Sep 4, 2022

As part of this, I should probably also start testing the options.html page that already exists in the test extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

1 participant