Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support messaging with the offscreen page #273

Open
fungairino opened this issue Nov 7, 2024 · 2 comments · May be fixed by #276
Open

Support messaging with the offscreen page #273

fungairino opened this issue Nov 7, 2024 · 2 comments · May be fixed by #276
Assignees
Labels
developer experience enhancement New feature or request javascript Pull requests that update Javascript code

Comments

@fungairino
Copy link
Collaborator

  • The offscreen page’s __getTabData call was throwing an error, causing the correct receiver to fail in responding with the right tabData.
  • The offscreen page, similar to the background service worker, lacks a tab, which this library did not handle correctly.

Notes:
See change that was reverted due to this bug: pixiebrix/pixiebrix-extension@2021198

Action item from: https://www.notion.so/pixiebrix/Postmortem-Release-2-1-6-13543b21a253809bab4cd2aace909433?pvs=4

@fungairino fungairino added developer experience enhancement New feature or request javascript Pull requests that update Javascript code labels Nov 7, 2024
@grahamlangford
Copy link
Collaborator

Related: fregante/webext-detect#32

@fregante
Copy link
Collaborator

fregante commented Nov 8, 2024

I added support for offscreen document detection to webext-detect:

As mentioned in an email to Todd, the messenger was likely failing because the offscreen document was not being properly detected. Also this line needs isBackground() || isOffscreenDocument()

isBackground() ? "not-needed" : "needed";

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer experience enhancement New feature or request javascript Pull requests that update Javascript code
Development

Successfully merging a pull request may close this issue.

3 participants