Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail when trace.length > 2 #221

Open
fregante opened this issue Mar 20, 2024 · 2 comments
Open

Fail when trace.length > 2 #221

fregante opened this issue Mar 20, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@fregante
Copy link
Collaborator

Additional safety check following:

This is not the right solution to the issue since it will trigger an error, but it should avoid loops in the future.

@fregante fregante added the enhancement New feature or request label Mar 20, 2024
@fregante fregante self-assigned this Mar 20, 2024
@twschiller
Copy link
Collaborator

twschiller commented Mar 20, 2024

This is not the right solution to the issue since it will trigger an error

I think this check is a good fail-safe

Is another guardrail that sender should ignore/drop/not forward any messages where it would be forwarding it to the same target as itself?

@fregante
Copy link
Collaborator Author

I can leave a comment for that in the future, but if I limit forwarding to the background page then neither one of these situations should happen

@fregante fregante removed their assignment Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

2 participants