From 4a12819b82f740c08d497d36382d354532af4a9e Mon Sep 17 00:00:00 2001 From: pit-ray Date: Mon, 9 Oct 2023 04:42:06 +0900 Subject: [PATCH] fix performance issue from coverity --- src/bind/syscmd/autocmd.cpp | 2 +- src/bind/window/arrange_win.cpp | 2 +- src/core/version.hpp | 2 +- src/opt/optionlist.cpp | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/bind/syscmd/autocmd.cpp b/src/bind/syscmd/autocmd.cpp index 2aff7ca3..ab27f4f6 100644 --- a/src/bind/syscmd/autocmd.cpp +++ b/src/bind/syscmd/autocmd.cpp @@ -83,7 +83,7 @@ namespace vind auto [event_str, patcmd] = core::extract_double_args(pargs) ; auto [pattern, cmd] = core::extract_double_args(patcmd) ; - auto patterns = util::split(pattern, ",") ; + auto patterns = util::split(std::move(pattern), ",") ; if(event_str == "*") { if(patterns.empty()) { diff --git a/src/bind/window/arrange_win.cpp b/src/bind/window/arrange_win.cpp index d7efdf6f..78392a0d 100644 --- a/src/bind/window/arrange_win.cpp +++ b/src/bind/window/arrange_win.cpp @@ -195,7 +195,7 @@ namespace vind auto& settable = core::SetTable::get_instance() ; auto str = settable.get("arrangewin_ignore").get() ; - auto modules = util::split(str, ",") ; + auto modules = util::split(std::move(str), ",") ; for(auto& m : modules) { g_ignores.insert(util::A2a(util::trim(m))) ; } diff --git a/src/core/version.hpp b/src/core/version.hpp index b92d7131..4ec2c9dc 100644 --- a/src/core/version.hpp +++ b/src/core/version.hpp @@ -1,6 +1,6 @@ #ifndef _VERSION_HPP #define _VERSION_HPP -#define WIN_VIND_VERSION "5.3.0.0" +#define WIN_VIND_VERSION "5.4.0.0" #endif diff --git a/src/opt/optionlist.cpp b/src/opt/optionlist.cpp index 7698f2ed..64f6668b 100644 --- a/src/opt/optionlist.cpp +++ b/src/opt/optionlist.cpp @@ -34,7 +34,7 @@ namespace vind Option::SPtr ref_global_options_byname(std::string&& name) { for(auto& opt : all_global_options()) { - if(opt->name() == util::A2a(name)) { + if(opt->name() == util::A2a(std::move(name))) { return opt ; } }