Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build 34 - version-major #536

Merged
merged 1 commit into from
Jun 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ The file format of it is based on [Keep a Changelog](http://keepachangelog.com/e
For public Changelog covering all changes done to Pipedrive’s API, webhooks and app extensions platforms, see [public Changelog](https://pipedrive.readme.io/docs/changelog) with discussion area in [Developers Community](https://devcommunity.pipedrive.com/c/documentation/changelog/19).

## [Unreleased]
### Removed
- Removed request and response fields `duration` and `duration_unit` for all endpoints of deals and products using them

## [22.10.1] - 2024-06-07
### Removed
Expand Down
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -809,7 +809,6 @@ Class | Method | HTTP request | Description
- [Pipedrive.DealPersonDataWithId](https://github.com/pipedrive/client-nodejs/blob/master/docs/DealPersonDataWithId.md)
- [Pipedrive.DealPersonDataWithIdAllOf](https://github.com/pipedrive/client-nodejs/blob/master/docs/DealPersonDataWithIdAllOf.md)
- [Pipedrive.DealProductRequestBody](https://github.com/pipedrive/client-nodejs/blob/master/docs/DealProductRequestBody.md)
- [Pipedrive.DealProductUnitDuration](https://github.com/pipedrive/client-nodejs/blob/master/docs/DealProductUnitDuration.md)
- [Pipedrive.DealSearchItem](https://github.com/pipedrive/client-nodejs/blob/master/docs/DealSearchItem.md)
- [Pipedrive.DealSearchItemItem](https://github.com/pipedrive/client-nodejs/blob/master/docs/DealSearchItemItem.md)
- [Pipedrive.DealSearchItemItemOrganization](https://github.com/pipedrive/client-nodejs/blob/master/docs/DealSearchItemItemOrganization.md)
Expand Down
2 changes: 0 additions & 2 deletions docs/AddProductAttachmentDetails.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@ Name | Type | Description | Notes
**quantity** | **Number** | Quantity – e.g. how many items of this product will be added to the deal | [optional]
**discount** | **Number** | The value of the discount. The `discount_type` field can be used to specify whether the value is an amount or a percentage | [optional] [default to 0]
**discount_type** | **String** | The type of the discount's value | [optional] [default to 'percentage']
**duration** | **Number** | The duration of the product. If omitted, will be set to 1 | [optional] [default to 1]
**duration_unit** | **String** | The type of the duration. (For example hourly, daily, etc.) | [optional]
**product_variation_id** | **Number** | The ID of the product variation to use. When omitted, no variation will be used | [optional]
**comments** | **String** | A textual comment associated with this product-deal attachment | [optional]
**tax** | **Number** | The product tax | [optional]
Expand Down
2 changes: 0 additions & 2 deletions docs/BasicDealProduct.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@ Name | Type | Description | Notes
**quantity** | **Number** | Quantity – e.g. how many items of this product will be added to the deal | [optional]
**discount** | **Number** | The value of the discount. The `discount_type` field can be used to specify whether the value is an amount or a percentage | [optional] [default to 0]
**discount_type** | **String** | The type of the discount's value | [optional] [default to 'percentage']
**duration** | **Number** | The duration of the product. If omitted, will be set to 1 | [optional] [default to 1]
**duration_unit** | [**DealProductUnitDuration**](DealProductUnitDuration.md) | The unit duration of the product | [optional]
**product_variation_id** | **Number** | The ID of the product variation to use. When omitted, no variation will be used | [optional]
**comments** | **String** | A textual comment associated with this product-deal attachment | [optional]
**tax** | **Number** | The tax percentage | [optional] [default to 0]
Expand Down
2 changes: 0 additions & 2 deletions docs/BasicDealProductAllOf.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@ Name | Type | Description | Notes
**quantity** | **Number** | Quantity – e.g. how many items of this product will be added to the deal | [optional]
**discount** | **Number** | The value of the discount. The `discount_type` field can be used to specify whether the value is an amount or a percentage | [optional] [default to 0]
**discount_type** | **String** | The type of the discount's value | [optional] [default to 'percentage']
**duration** | **Number** | The duration of the product. If omitted, will be set to 1 | [optional] [default to 1]
**duration_unit** | [**DealProductUnitDuration**](DealProductUnitDuration.md) | The unit duration of the product | [optional]
**product_variation_id** | **Number** | The ID of the product variation to use. When omitted, no variation will be used | [optional]
**comments** | **String** | A textual comment associated with this product-deal attachment | [optional]
**tax** | **Number** | The tax percentage | [optional] [default to 0]
Expand Down
2 changes: 0 additions & 2 deletions docs/DealProductRequestBody.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@ Name | Type | Description | Notes
**quantity** | **Number** | How many items of this product will be added to the deal | [optional]
**discount** | **Number** | The value of the discount. The `discount_type` field can be used to specify whether the value is an amount or a percentage | [optional] [default to 0]
**discount_type** | **String** | The type of the discount's value | [optional] [default to 'percentage']
**duration** | **Number** | The duration of the product | [optional] [default to 1]
**duration_unit** | [**DealProductUnitDuration**](DealProductUnitDuration.md) | The unit duration of the product | [optional]
**product_variation_id** | **Number** | The ID of the product variation to use. When omitted, no variation will be used | [optional]
**comments** | **String** | A textual comment associated with this product-deal attachment | [optional]
**tax** | **Number** | The tax percentage | [optional] [default to 0]
Expand Down
2 changes: 0 additions & 2 deletions docs/NewDealProduct.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@ Name | Type | Description | Notes
**quantity** | **Number** | How many items of this product will be added to the deal | [optional]
**discount** | **Number** | The value of the discount. The `discount_type` field can be used to specify whether the value is an amount or a percentage | [optional] [default to 0]
**discount_type** | **String** | The type of the discount's value | [optional] [default to 'percentage']
**duration** | **Number** | The duration of the product | [optional] [default to 1]
**duration_unit** | [**DealProductUnitDuration**](DealProductUnitDuration.md) | The unit duration of the product | [optional]
**product_variation_id** | **Number** | The ID of the product variation to use. When omitted, no variation will be used | [optional]
**comments** | **String** | A textual comment associated with this product-deal attachment | [optional]
**tax** | **Number** | The tax percentage | [optional] [default to 0]
Expand Down
1 change: 0 additions & 1 deletion docs/ProductAttachementFields.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ Name | Type | Description | Notes
**company_id** | **Number** | The ID of the company | [optional]
**deal_id** | **Number** | The ID of the deal | [optional]
**product_id** | **Number** | The ID of the product | [optional]
**duration_unit** | **String** | The type of the duration. (For example hourly, daily, etc.) | [optional]
**sum** | **Number** | The sum of all the products attached to the deal | [optional]
**currency** | **String** | The currency associated with the deal product | [optional]
**add_time** | **String** | The date and time when the product was added to the deal | [optional]
Expand Down
2 changes: 0 additions & 2 deletions docs/ProductAttachmentDetails.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@ Name | Type | Description | Notes
**quantity** | **Number** | Quantity – e.g. how many items of this product will be added to the deal | [optional]
**discount** | **Number** | The value of the discount. The `discount_type` field can be used to specify whether the value is an amount or a percentage | [optional] [default to 0]
**discount_type** | **String** | The type of the discount's value | [optional] [default to 'percentage']
**duration** | **Number** | The duration of the product. If omitted, will be set to 1 | [optional] [default to 1]
**duration_unit** | **String** | The type of the duration. (For example hourly, daily, etc.) | [optional]
**product_variation_id** | **Number** | The ID of the product variation to use. When omitted, no variation will be used | [optional]
**comments** | **String** | A textual comment associated with this product-deal attachment | [optional]
**tax** | **Number** | The product tax | [optional]
Expand Down
2 changes: 0 additions & 2 deletions docs/ProductListItem.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@ Name | Type | Description | Notes
**item_price** | **Number** | The price value of the product | [optional]
**discount** | **Number** | The value of the discount. The `discount_type` field can be used to specify whether the value is an amount or a percentage | [optional] [default to 0]
**discount_type** | **String** | The type of the discount's value | [optional] [default to 'percentage']
**duration** | **Number** | The duration of the product | [optional]
**duration_unit** | **String** | The type of the duration. (For example hourly, daily, etc.) | [optional]
**sum** | **Number** | The sum of all the products attached to the deal | [optional]
**currency** | **String** | The currency associated with the deal product | [optional]
**enabled_flag** | **Boolean** | Whether the product is enabled or not | [optional]
Expand Down
2 changes: 0 additions & 2 deletions docs/UpdateDealProduct.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@ Name | Type | Description | Notes
**quantity** | **Number** | How many items of this product will be added to the deal | [optional]
**discount** | **Number** | The value of the discount. The `discount_type` field can be used to specify whether the value is an amount or a percentage | [optional] [default to 0]
**discount_type** | **String** | The type of the discount's value | [optional] [default to 'percentage']
**duration** | **Number** | The duration of the product | [optional] [default to 1]
**duration_unit** | [**DealProductUnitDuration**](DealProductUnitDuration.md) | The unit duration of the product | [optional]
**product_variation_id** | **Number** | The ID of the product variation to use. When omitted, no variation will be used | [optional]
**comments** | **String** | A textual comment associated with this product-deal attachment | [optional]
**tax** | **Number** | The tax percentage | [optional] [default to 0]
Expand Down
7 changes: 0 additions & 7 deletions src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,6 @@ import DealPersonDataPhone from './model/DealPersonDataPhone';
import DealPersonDataWithId from './model/DealPersonDataWithId';
import DealPersonDataWithIdAllOf from './model/DealPersonDataWithIdAllOf';
import DealProductRequestBody from './model/DealProductRequestBody';
import DealProductUnitDuration from './model/DealProductUnitDuration';
import DealSearchItem from './model/DealSearchItem';
import DealSearchItemItem from './model/DealSearchItemItem';
import DealSearchItemItemOrganization from './model/DealSearchItemItemOrganization';
Expand Down Expand Up @@ -1977,12 +1976,6 @@ export {
*/
DealProductRequestBody,

/**
* The DealProductUnitDuration model constructor.
* @property {module:model/DealProductUnitDuration}
*/
DealProductUnitDuration,

/**
* The DealSearchItem model constructor.
* @property {module:model/DealSearchItem}
Expand Down
34 changes: 0 additions & 34 deletions src/model/AddProductAttachmentDetails.js
Original file line number Diff line number Diff line change
Expand Up @@ -79,16 +79,6 @@ class AddProductAttachmentDetails {

delete data['discount_type'];
}
if (data.hasOwnProperty('duration')) {
obj['duration'] = ApiClient.convertToType(data['duration'], 'Number');

delete data['duration'];
}
if (data.hasOwnProperty('duration_unit')) {
obj['duration_unit'] = ApiClient.convertToType(data['duration_unit'], 'String');

delete data['duration_unit'];
}
if (data.hasOwnProperty('product_variation_id')) {
obj['product_variation_id'] = ApiClient.convertToType(data['product_variation_id'], 'Number');

Expand Down Expand Up @@ -223,19 +213,6 @@ AddProductAttachmentDetails.prototype['discount'] = 0;
*/
AddProductAttachmentDetails.prototype['discount_type'] = 'percentage';

/**
* The duration of the product. If omitted, will be set to 1
* @member {Number} duration
* @default 1
*/
AddProductAttachmentDetails.prototype['duration'] = 1;

/**
* The type of the duration. (For example hourly, daily, etc.)
* @member {String} duration_unit
*/
AddProductAttachmentDetails.prototype['duration_unit'] = undefined;

/**
* The ID of the product variation to use. When omitted, no variation will be used
* @member {Number} product_variation_id
Expand Down Expand Up @@ -373,17 +350,6 @@ ProductAttachmentDetails.prototype['discount'] = 0;
* @default 'percentage'
*/
ProductAttachmentDetails.prototype['discount_type'] = 'percentage';
/**
* The duration of the product. If omitted, will be set to 1
* @member {Number} duration
* @default 1
*/
ProductAttachmentDetails.prototype['duration'] = 1;
/**
* The type of the duration. (For example hourly, daily, etc.)
* @member {String} duration_unit
*/
ProductAttachmentDetails.prototype['duration_unit'] = undefined;
/**
* The ID of the product variation to use. When omitted, no variation will be used
* @member {Number} product_variation_id
Expand Down
35 changes: 0 additions & 35 deletions src/model/BasicDealProduct.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
import ApiClient from '../ApiClient';
import BasicDealProductAllOf from './BasicDealProductAllOf';
import BillingFrequency from './BillingFrequency';
import DealProductUnitDuration from './DealProductUnitDuration';
import NewDealProductAllOf from './NewDealProductAllOf';
import NewDealProductAllOf1 from './NewDealProductAllOf1';
import NewDealProductAllOf2 from './NewDealProductAllOf2';
Expand Down Expand Up @@ -86,16 +85,6 @@ class BasicDealProduct {

delete data['discount_type'];
}
if (data.hasOwnProperty('duration')) {
obj['duration'] = ApiClient.convertToType(data['duration'], 'Number');

delete data['duration'];
}
if (data.hasOwnProperty('duration_unit')) {
obj['duration_unit'] = ApiClient.convertToType(data['duration_unit'], DealProductUnitDuration);

delete data['duration_unit'];
}
if (data.hasOwnProperty('product_variation_id')) {
obj['product_variation_id'] = ApiClient.convertToType(data['product_variation_id'], 'Number');

Expand Down Expand Up @@ -180,19 +169,6 @@ BasicDealProduct.prototype['discount'] = 0;
*/
BasicDealProduct.prototype['discount_type'] = 'percentage';

/**
* The duration of the product. If omitted, will be set to 1
* @member {Number} duration
* @default 1
*/
BasicDealProduct.prototype['duration'] = 1;

/**
* The unit duration of the product
* @member {module:model/DealProductUnitDuration} duration_unit
*/
BasicDealProduct.prototype['duration_unit'] = undefined;

/**
* The ID of the product variation to use. When omitted, no variation will be used
* @member {Number} product_variation_id
Expand Down Expand Up @@ -271,17 +247,6 @@ BasicDealProductAllOf.prototype['discount'] = 0;
* @default 'percentage'
*/
BasicDealProductAllOf.prototype['discount_type'] = 'percentage';
/**
* The duration of the product. If omitted, will be set to 1
* @member {Number} duration
* @default 1
*/
BasicDealProductAllOf.prototype['duration'] = 1;
/**
* The unit duration of the product
* @member {module:model/DealProductUnitDuration} duration_unit
*/
BasicDealProductAllOf.prototype['duration_unit'] = undefined;
/**
* The ID of the product variation to use. When omitted, no variation will be used
* @member {Number} product_variation_id
Expand Down
24 changes: 0 additions & 24 deletions src/model/BasicDealProductAllOf.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
*/

import ApiClient from '../ApiClient';
import DealProductUnitDuration from './DealProductUnitDuration';

/**
* The BasicDealProductAllOf model module.
Expand Down Expand Up @@ -73,16 +72,6 @@ class BasicDealProductAllOf {

delete data['discount_type'];
}
if (data.hasOwnProperty('duration')) {
obj['duration'] = ApiClient.convertToType(data['duration'], 'Number');

delete data['duration'];
}
if (data.hasOwnProperty('duration_unit')) {
obj['duration_unit'] = ApiClient.convertToType(data['duration_unit'], DealProductUnitDuration);

delete data['duration_unit'];
}
if (data.hasOwnProperty('product_variation_id')) {
obj['product_variation_id'] = ApiClient.convertToType(data['product_variation_id'], 'Number');

Expand Down Expand Up @@ -152,19 +141,6 @@ BasicDealProductAllOf.prototype['discount'] = 0;
*/
BasicDealProductAllOf.prototype['discount_type'] = 'percentage';

/**
* The duration of the product. If omitted, will be set to 1
* @member {Number} duration
* @default 1
*/
BasicDealProductAllOf.prototype['duration'] = 1;

/**
* The unit duration of the product
* @member {module:model/DealProductUnitDuration} duration_unit
*/
BasicDealProductAllOf.prototype['duration_unit'] = undefined;

/**
* The ID of the product variation to use. When omitted, no variation will be used
* @member {Number} product_variation_id
Expand Down
24 changes: 0 additions & 24 deletions src/model/DealProductRequestBody.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
*/

import ApiClient from '../ApiClient';
import DealProductUnitDuration from './DealProductUnitDuration';

/**
* The DealProductRequestBody model module.
Expand Down Expand Up @@ -73,16 +72,6 @@ class DealProductRequestBody {

delete data['discount_type'];
}
if (data.hasOwnProperty('duration')) {
obj['duration'] = ApiClient.convertToType(data['duration'], 'Number');

delete data['duration'];
}
if (data.hasOwnProperty('duration_unit')) {
obj['duration_unit'] = ApiClient.convertToType(data['duration_unit'], DealProductUnitDuration);

delete data['duration_unit'];
}
if (data.hasOwnProperty('product_variation_id')) {
obj['product_variation_id'] = ApiClient.convertToType(data['product_variation_id'], 'Number');

Expand Down Expand Up @@ -152,19 +141,6 @@ DealProductRequestBody.prototype['discount'] = 0;
*/
DealProductRequestBody.prototype['discount_type'] = 'percentage';

/**
* The duration of the product
* @member {Number} duration
* @default 1
*/
DealProductRequestBody.prototype['duration'] = 1;

/**
* The unit duration of the product
* @member {module:model/DealProductUnitDuration} duration_unit
*/
DealProductRequestBody.prototype['duration_unit'] = undefined;

/**
* The ID of the product variation to use. When omitted, no variation will be used
* @member {Number} product_variation_id
Expand Down
Loading
Loading