We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
commitMatcher
What would you like to be added:
Support commitMatcher for CloudRunApp, TerraformApp, ECSApp, and LambdaApp.
Why is this needed:
Currently, commitMatcher is only supported for K8sApp as below:
K8sApp:
pipecd/pkg/app/piped/planner/kubernetes/kubernetes.go
Lines 166 to 196 in 8129078
ECSApp: does not have such logic. (CloudRun, Lambda, Terraform too) https://github.com/pipe-cd/pipecd/blob/master/pkg/app/piped/planner/ecs/ecs.go
[IMO] Such logic should be placed in the common planner.go, not platform-specific files.
The text was updated successfully, but these errors were encountered:
I found the docs is correct. commitMatcher exists only in KubernetesApp
KubernetesApp
Sorry, something went wrong.
Support it on the pipedv1.
No branches or pull requests
What would you like to be added:
Support
commitMatcher
for CloudRunApp, TerraformApp, ECSApp, and LambdaApp.Why is this needed:
Currently,
commitMatcher
is only supported for K8sApp as below:K8sApp:
pipecd/pkg/app/piped/planner/kubernetes/kubernetes.go
Lines 166 to 196 in 8129078
ECSApp: does not have such logic. (CloudRun, Lambda, Terraform too)
https://github.com/pipe-cd/pipecd/blob/master/pkg/app/piped/planner/ecs/ecs.go
[IMO] Such logic should be placed in the common planner.go, not platform-specific files.
The text was updated successfully, but these errors were encountered: