Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP feat(collision-detection): move to web worker #53

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

WIP feat(collision-detection): move to web worker #53

wants to merge 2 commits into from

Conversation

pinussilvestrus
Copy link
Owner

@pinussilvestrus pinussilvestrus commented Mar 22, 2019 •
edited
Loading

Closes #52

  • Moves collision detection to own module
  • Wrap into web worker by using threadify

@codecov
Copy link

codecov bot commented Mar 22, 2019 •
edited
Loading

Codecov Report

Merging #53 into master will decrease coverage by 8.85%.
The diff coverage is 37.03%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
- Coverage   98.52%   89.67%   -8.86%     
==========================================
  Files           6        8       +2     
  Lines         203      213      +10     
==========================================
- Hits          200      191       -9     
- Misses          3       22      +19
Impacted Files Coverage Δ
lib/canvas/canvas.js 100% <ø> (ø) ⬆️
lib/threadify/threadify.min.js 100% <100%> (ø)
lib/collision-detection/collisionDetection.js 29.41% <29.41%> (ø)
lib/main/main.js 80.39% <44.44%> (-12.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ac52da...dd84ff6. Read the comment docs.

@pinussilvestrus pinussilvestrus force-pushed the 52-collision-detection-web-worker branch from 592aac7 to f7f2e9a Compare March 22, 2019 17:44
@pinussilvestrus pinussilvestrus force-pushed the 52-collision-detection-web-worker branch from f7f2e9a to 9d43fc4 Compare March 22, 2019 17:46
@pinussilvestrus pinussilvestrus force-pushed the 52-collision-detection-web-worker branch from c0249fd to dd84ff6 Compare March 22, 2019 18:10
Base automatically changed from master to main March 15, 2021 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move obstacle collision detection to web worker
1 participant
@pinussilvestrus