Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aren't you going to release a new version? #45

Open
Hackjjang opened this issue Jul 7, 2023 · 8 comments
Open

Aren't you going to release a new version? #45

Hackjjang opened this issue Jul 7, 2023 · 8 comments

Comments

@Hackjjang
Copy link

It's a shame that the code update hasn't been released for almost half a year, as it seems to be going well.
I'm using it on MPC-HC or MPC-BE, but I'd like to try the new modified one.

@pinterf
Copy link
Owner

pinterf commented Jul 7, 2023

Hi, due to being busy in other areas of life I'm not following the project closely, and I'm not even aware that it is still used by people.

On the other hand, since there was some activity again in the original repo (see https://github.com/Cyberbeing/xy-VSFilter/commits/xy_sub_filter_rc5), which I considered to be dead years ago (as it was indeed dead at that time), I guessed my repo was no longer valid, though I think it contains modifications which do not exist there.

@Potmarigold
Copy link

Is it possible for you to keep improving xy-VSFilter since the subtitle feature of MPC-BE is not very good?

A lot of people use xy-VSFilter because the subtitle function on MPC-BE is so poor.

@astiob
Copy link
Contributor

astiob commented Nov 8, 2023

On the other hand, since there was some activity again in the original repo (see https://github.com/Cyberbeing/xy-VSFilter/commits/xy_sub_filter_rc5), which I considered to be dead years ago (as it was indeed dead at that time), I guessed my repo was no longer valid, though I think it contains modifications which do not exist there.

To clarify, it seems Cyberbeing checked on the open pull requests briefly but was too busy to return to active maintenance personally. He did give write access to Oneric and me, though.

Of the several PRs he merged himself, one was (intentionally) exactly mirrored in this repo. The other few though, I don’t know. @Masaiki, are those just mirrors/ports of code that’s already in pinterf’s fork, or is something new included as well?

If you feel that you no longer have the energy to maintain VSFilter actively either, one possible course of action is to merge the two repos into one. Since we have write access now, it can be Cyberbeing’s if you feel that’s more appropriate. Otherwise, you’ll probably want to merge the few new changes from Cyberbeing’s repo here.

@Masaiki
Copy link
Contributor

Masaiki commented Nov 8, 2023

are those just mirrors/ports of code that’s already in pinterf’s fork, or is something new included as well?

@astiob Cyberbeing/xy-VSFilter#22 & Cyberbeing/xy-VSFilter#21 from https://github.com/Masaiki/xy-VSFilter
Cyberbeing/xy-VSFilter#20 from VSFilter in MPC-BE

@astiob
Copy link
Contributor

astiob commented Nov 8, 2023

I’ll take that as “they’re not in pinterf’s fork”.

@pinterf
Copy link
Owner

pinterf commented Nov 8, 2023

Sure, I have no energy - and active knowledge - for the project maintenance, but merging a finite number of changes is probably not a big task. I can give write access as well, which is better and quicker for the community.

@TheOneric
Copy link
Contributor

Backported most of the recent changes in #46

@pinterf
Copy link
Owner

pinterf commented Jan 2, 2024

Thank you for your work.
https://github.com/pinterf/xy-VSFilter/releases/tag/3.2.0.809

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants