Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for blocking pools #519

Open
scott-8 opened this issue May 25, 2023 · 2 comments
Open

Add support for blocking pools #519

scott-8 opened this issue May 25, 2023 · 2 comments
Labels
enhancement newbie

Comments

@scott-8
Copy link

scott-8 commented May 25, 2023

Right now, a RunetimeError is raised is no connections are available in a pool. It would be helpful if there were an option to block the thread instead. Redis and pylibmc have examples of this.
@JoJo10Smith
Copy link

JoJo10Smith commented Aug 14, 2023 •
edited
Loading

@jogo I'd like to try and work on this issue but I have a few questions about the function:

  • Should I be creating a new function or just adding the option to block in the get() function in pool.py?

I could submit a PR sometime this week with my potential solution based on the feedback to my questions above.
Thanks

@JoJo10Smith JoJo10Smith mentioned this issue Aug 16, 2023
Open
@jogo
Copy link
Contributor

jogo commented Nov 22, 2023

sorry for the slow response, I think a new option in get would be preferable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement newbie
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jogo @scott-8 @JoJo10Smith