Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from AssertJ to AssertK #2586

Open
Goooler opened this issue Mar 2, 2024 · 2 comments
Open

Migrate from AssertJ to AssertK #2586

Goooler opened this issue Mar 2, 2024 · 2 comments
Labels
Parked Issue is not likely to be solved or has no clear resolution yet

Comments

@Goooler
Copy link
Contributor

Goooler commented Mar 2, 2024

AssertK is a fluent assertion library for Kotlin, which is designed with Kotlin idioms. It would be nice to migrate to that.

https://github.com/willowtreeapps/assertk
@Goooler Goooler changed the title Migrate AssertJ to AssertK Migrate from AssertJ to AssertK Mar 2, 2024
@paul-dingemans
Copy link
Collaborator

Currently I see no benefits of migrating ktlint from Assertj to Assertk. Most of the tests are based on ktlint's internal dsl for validating lint/format issues. That dsl is quite complex and might be simplified when using Assertk. I will mark the issue as parked, but if someone else would like to pick it up I am okay with that.

@paul-dingemans paul-dingemans added the Parked Issue is not likely to be solved or has no clear resolution yet label Mar 3, 2024
@Goooler
Copy link
Contributor Author

Goooler commented Mar 3, 2024

That dsl is quite complex and might be simplified when using Assertk.

I see it too. Will take a look when I'm free of time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Parked Issue is not likely to be solved or has no clear resolution yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@paul-dingemans @Goooler