Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#11705] Refactor PluginTestEngine #11738

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Conversation

emeroad
Copy link
Member

@emeroad emeroad commented Nov 19, 2024

No description provided.

@emeroad emeroad added this to the 3.1.0 milestone Nov 19, 2024
@emeroad emeroad linked an issue Nov 19, 2024 that may be closed by this pull request
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 17.58242% with 150 lines in your changes missing coverage. Please review.

Project coverage is 36.90%. Comparing base (13dffbb) to head (fc3e0a9).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...junit5/engine/discovery/TestDescriptorFactory.java 0.00% 45 Missing ⚠️
.../engine/discovery/PluginTestDescriptorBuilder.java 8.33% 22 Missing ⚠️
...e/discovery/PluginForkedTestDescriptorBuilder.java 9.09% 20 Missing ⚠️
...inpoint/test/plugin/DefaultPluginTestInstance.java 0.00% 16 Missing ⚠️
...ne/discovery/PluginJunitTestDescriptorBuilder.java 15.38% 11 Missing ⚠️
...t5/engine/discovery/PluginPostDiscoveryFilter.java 65.21% 2 Missing and 6 partials ⚠️
...nit5/descriptor/PluginTestClassTestDescriptor.java 0.00% 4 Missing ⚠️
...point/test/plugin/shared/PluginSharedInstance.java 0.00% 4 Missing ⚠️
...inpoint/test/plugin/PluginTestInstanceFactory.java 0.00% 3 Missing ⚠️
...nt/test/plugin/junit5/engine/PluginTestEngine.java 70.00% 2 Missing and 1 partial ⚠️
... and 9 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #11738      +/-   ##
============================================
+ Coverage     36.89%   36.90%   +0.01%     
- Complexity    12397    12405       +8     
============================================
  Files          4104     4104              
  Lines        100677   100684       +7     
  Branches      10542    10538       -4     
============================================
+ Hits          37142    37156      +14     
- Misses        60539    60540       +1     
+ Partials       2996     2988       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@emeroad emeroad merged commit 0acb8e7 into pinpoint-apm:master Nov 19, 2024
2 of 3 checks passed
@emeroad emeroad deleted the #11705_junit branch November 20, 2024 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump junit-jupiter 5.10.2 from to 5.11.3
1 participant