New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sample 2 won't work as expected. #35

Open

jejayhe opened this issue Mar 12, 2021 · 1 comment

jejayhe commented Mar 12, 2021

https://github.com/pinpoint-apm/pinpoint-plugin-sample/blob/master/plugin/src/main/java/com/navercorp/pinpoint/plugin/sample/_02_Injecting_Custom_Interceptor/RecordArgsAndReturnValueInterceptor.java
line110 wouldn't show arg0 in pinpoint-web
since https://github.com/pinpoint-apm/pinpoint-plugin-sample/blob/master/plugin/src/main/resources/META-INF/pinpoint/type-provider.yml
line5 it only matches code 998.
Do I understand that right?

jaehong-kim commented Jun 4, 2021

@jejayhe
Modified the sample.

https://github.com/pinpoint-apm/pinpoint-plugin-sample/blob/master/plugins/sample/src/main/java/com/navercorp/pinpoint/plugin/sample/_02_Injecting_Custom_Interceptor/RecordArgsAndReturnValueInterceptor.java

recorder.recordApi(descriptor);
recorder.recordAttribute(SamplePluginConstants.ANNOTATION_KEY_MY_VALUE, arg0);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment