Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/syncfalse.test.js test failure #2074

Open
pacostas opened this issue Nov 4, 2024 · 3 comments
Open

test/syncfalse.test.js test failure #2074

pacostas opened this issue Nov 4, 2024 · 3 comments

Comments

@pacostas
Copy link

pacostas commented Nov 4, 2024

Description

The below error appears after running the tests on centos 9 and rhel9 with node 22. There is no error with node 20 on the centos 9 and in rhel9, so this error has a lot of chances of being related to the node version in combination with the platform.

 FAIL ​ test/syncfalse.test.js
#8 32.58  ✖ should be equal
#8 32.58 
#8 32.58   test/syncfalse.test.js
#8 32.58   63 |   await sleep(100)
#8 32.58   64 |   equal(actual, expected)
#8 32.58 > 65 |   equal(actual2.trim(), expected2)
#8 32.58      | --^
#8 32.58   66 |
#8 32.58   67 |   teardown(() => {
#8 32.58   68 |     os.hostname = hostname
#8 32.58 
#8 32.58   test: test/syncfalse.test.js asynchronous logging
#8 32.58   found: ""
#8 32.58   wanted: '{"level":30,"time":1459875739796,"pid":123456,"hostname":"abcdefghijk
#8 32.58 lmnopqr","msg":"h"}'
#8 32.58   compare: ===
#8 32.58   stack: |
#8 32.58     Test.<anonymous> (test/syncfalse.test.js:65:3)

Steps to reproduce:

  1. create below docker file
cat <<EOF > containerfile.c9s
FROM quay.io/sclorg/nodejs-22-c9s

WORKDIR /usr/src/app

RUN git clone https://github.com/pinojs/pino.git
RUN cd pino && npm i --ignore-scripts
RUN cd pino && npm run test-ci
EOF
  1. build dockerfile
docker build . -f ./containerfile.c9s
@pacostas pacostas changed the title Pino tests failling test/syncfalse.test.js test failure Nov 4, 2024
@mcollina
Copy link
Member

Would you like to send a PR?

I think the solution is to increase that timer above that line.

@pacostas
Copy link
Author

I tried increasing it to await sleep(100000) but the error still occurs

@mcollina
Copy link
Member

I'm not really sure how to handle this, as I'm not really a RedHat user, but I think this should be solved - and I have no real time to dedicate here.

A PR that fixes this would be highly welcomed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants