New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readFile() leaking #8

Open

benkirk7 opened this issue May 10, 2021 · 2 comments

Labels

good first issue

benkirk7 commented May 10, 2021

This function does not automatically close the file if passed as a fd.

Member

mcollina commented May 10, 2021

Would you like to send a Pull Request to address this issue? Remember to add unit tests.

Author

benkirk7 commented May 10, 2021

I don't have the time right now putting out fires at work, but the fix is easy... just call fs.close(fd, callback).

mcollina added the good first issue label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment