Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating for v9 #63

Closed
Ranieri93 opened this issue Oct 7, 2023 · 5 comments
Closed

Updating for v9 #63

Ranieri93 opened this issue Oct 7, 2023 · 5 comments

Comments

@Ranieri93
Copy link

Hello everyone!
Following the order on issue #1762 I would like to work on the update for v9.

A few general considerations:

  • NPM stats display a total of 1.2 million downloads in the last year
  • The last commit dates back to August last year
  • It has a direct dependency with pino-http

My evaluation would be to keep this updated because, despite not being that active, the download numbers seem consistent.

I'll wait for your opinion before creating a PR.
@jsumners @mcollina

Thank you so much in advance for your time!

@jsumners
Copy link
Member

jsumners commented Oct 7, 2023

If this depends on pino-http, are you up for getting it ready as well?

@Ranieri93
Copy link
Author

If this depends on pino-http, are you up for getting it ready as well?

Yeah, sure!
Do you recommend updating that first? It will probably make sense as I guess some of the other libraries will depend on it

@jsumners
Copy link
Member

jsumners commented Oct 8, 2023

Yeah, I think that would be the correct approach. Given that these modules are in use by the ecosystem, we'll have to prepare them on next branches and reference the new dependency in this module via a git URL.

Please open an equivalent issue to this one on pino-http and I'll get things going.

@Ranieri93
Copy link
Author

Hey @jsumners, since this has already been merged, I think this issue could be considered done

@jsumners
Copy link
Member

I see. Thank you for the work and bringing this to my attention.

@github-project-automation github-project-automation bot moved this from Todo to Done in v9 Work Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants