New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Polish] TripPlanForm: Make pressing enter while inside a SearchBox do things #43

Open

pingzing opened this issue May 26, 2017 · 1 comment

Assignees

Labels

polish priority: high

Milestone

1.2 New Features

Owner

pingzing commented May 26, 2017

Pressing enter while inside any of the search boxes on the TripPlan page should do the following:

If the Plan button is enabled, trigger a plan for the current input.
If not, move to the next empty box.

pingzing added polish priority: high labels

pingzing added this to the 1.1 Bugfixes & Polish milestone

pingzing self-assigned this

Owner Author

pingzing commented May 29, 2017

Kinda works. Needs polish.

Problem: Focus returns to the searchbox after planning begins, and the popup is still visible.

Possible solutions: Disable the searchboxes, change the searchbox logic to not always show the popup on gaining focus.

Either way, pushing it back to 1.2. It's good enough for now.

pingzing modified the milestones: 1.2 New Features, 1.1 Bugfixes & Polish

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment