$menu->add method

[drparham]

When trying to create a menu item using the $menu->add method with the following:

$menu->add([
        'route' => 'dashboard.settings',
        'title' => 'Settings',
        'icon'  => 'fa fa-cog',
        'attributes' => [
            'target' => '_blank'
        ],
        'order' => 5
    ]);

option I get an error:
Route [d] not defined.
The Menu seems to be looking for the first character of the named route instead of the entire named route. Works fine if i switch to 'url' => 'path/name' like so:

$menu->add([
        'url' => 'dashboard/settings',
        'title' => 'Settings',
        'icon'  => 'fa fa-cog',
        'attributes' => [
            'target' => '_blank'
        ],
        'order' => 5
    ]);

Is this an error with the menu system, or an error in the documentation? How can i used named routes with the add method? As far as i can tell the only way to add an icon to a menu item is via the $menu->add method.

[gravitano]

You need to use array for route action.

$menu->add([
        'url' => ['dashboard/settings'],
        'title' => 'Settings',
        'icon'  => 'fa fa-cog',
        'attributes' => [
            'target' => '_blank'
        ],
        'order' => 5
    ]);

I would improve this feature in next release. Thanks!

[drparham]

If i change it to an array like this:

$menu->add([
            'route' => ['dashboard.settings'],
            'title' => 'Settings',
            'icon'  => 'fa fa-cog',
            'attributes' => [
            'target' => '_blank'
            ],
            'order' => 5
        ]);

I get an error in: MenuItem.php line 268:

return !empty($this->route) ? route($this->route[0], $this->route[1]) : url($this->url);

If i add an empty array to the route array like so:

       $menu->add([
            'route' => ['dashboard.settings',[]],
            'title' => 'Settings',
            'icon'  => 'fa fa-cog',
            'attributes' => [
            'target' => '_blank'
            ],
            'order' => 5
        ]);

That fixes the problem. If I add something besides an array it adds the ? to the end of the URI