Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] NoticeSettingsView queryset #60

Open
ka7eh opened this issue Feb 14, 2016 · 1 comment
Open

[Enhancement] NoticeSettingsView queryset #60

ka7eh opened this issue Feb 14, 2016 · 1 comment

Comments

@ka7eh
Copy link

ka7eh commented Feb 14, 2016

Thanks for this handy app!

Here is a suggestion for improving(?) the settings view:
Right now when users access settings view, they can update their settings for all NoticeTypes.
A project might have some notices which are important and must be sent and it is better not to let users to opt out of those.
One way to handle this situation is using default field to filter NoticeType queryset in NoticeSettingsView. For example:

# views.NoticeSettingsView
def settings_table(self):
        notice_types = NoticeType.objects.filter(default__lt=settings.FILTER_THRESHOLD)

Or if there is any other built-in solution, please let me know! :)

@ossanna16
Copy link

@paltman Any thoughts on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants