Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sleep timer #91

Closed
teq0 opened this issue Mar 29, 2015 · 3 comments
Closed

Add sleep timer #91

teq0 opened this issue Mar 29, 2015 · 3 comments
Labels

Comments

@teq0
Copy link

teq0 commented Mar 29, 2015

I've submitted a PR to mopidy - mopidy/mopidy#1085 - to add a sleep timer. If it gets accepted I've also written an extension for MusicBox Webclient to control it - https://github.com/teq0/Mopidy-MusicBox-Webclient/tree/feature/sleeptimer.

I've written it as a self-executing function so that the code is completely encapsulated, which keeps it nice and clean but it's quite a different style to the rest of the MusicBox Webclient. Should I refactor it into the more global style of the rest of the code? I'm not exactly sure where the various bits should go.

@jcass77
Copy link
Member

jcass77 commented Dec 23, 2015

Update: it appears that the Mopidy PR referenced above ultimately wasn't merged.

@DavisNT , this sounds like a useful feature to consider adding to Mopidy-AlarmClock?

@jcass77
Copy link
Member

jcass77 commented Feb 14, 2016

It does not appear as if the idea to develop a sleep timer extension for Mopidy was ever taken any further.

Should one become available in the future, then we should be able to integrate it in the web client fairly easily. For now though I think it is unlikely that this is something that we will build ourselves.

@jcass77
Copy link
Member

jcass77 commented Feb 16, 2016

Closing this in favour of this feature going into Mopidy-AlarmClock (see: DavisNT/mopidy-alarmclock#4).

@jcass77 jcass77 closed this as completed Feb 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants