Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Element Tree] Loading indicator #722

Open
markus-moser opened this issue Nov 21, 2024 · 4 comments
Open

[Element Tree] Loading indicator #722

markus-moser opened this issue Nov 21, 2024 · 4 comments
Assignees

Comments

@markus-moser
Copy link
Contributor

I guess we should do it like in the ant design tree:

https://ant.design/components/tree#tree-demo-dynamic

@vin0401
Copy link
Collaborator

vin0401 commented Nov 27, 2024

The loading indicator for folders and the initial loading is solved via: #746

But we should also discuss how to deal with the different context menu actions.
For example the deletion of an item invalidates the data of the tree and will force the loading indicator for the parent folder to appear when the deletion succeeds. What is perfectly fine. But we are missing an indication for the time where the deletion itself is still ongoing. Of course this also applies to several other actions.

@markus-moser @idaiv - Any ideas on this? I guess we need to take a deeper look at all the different behaviors from the context menu actions?

@markus-moser
Copy link
Contributor Author

@vin0401 I think we have something similar in the classic bundle:

Image

In my opinion the new approach should be similiar to this - WDYT?

@idaiv
Copy link

idaiv commented Nov 27, 2024

Hi @markus-moser and @vin0401!
The approach of ant for the tree is perfect! https://ant.design/components/tree#tree-demo-dynamic

But we should also discuss how to deal with the different context menu actions. For example the deletion of an item invalidates the data of the tree and will force the loading indicator for the parent folder to appear when the deletion succeeds. What is perfectly fine. But we are missing an indication for the time where the deletion itself is still ongoing. Of course this also applies to several other actions.

I would say if the loading indicator in this case is for the whole folder, what we can do to identify the element which deletion is in progress could be to blur it. That way it will have some color separation and blurred or lighter font in general communicates not available/ disabled/ etc. This is great to give a hint for the user initially. We can think of exchanging the element icon with the loading (https://ant.design/components/tree#tree-demo-dynamic) + blur to transparently show that this is not a permanent state but something is happening with this file and therefore its blurred as it is disabled right now.

WDYT?

@markus-moser
Copy link
Contributor Author

@idaiv Yes, this sounds like a good idea and is a very similar approach to the old UI - for sure we should not style it with the same red strikethrough, the blur sounds like it could work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants