Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] list view sorting by size does not work #624

Open
heigpa opened this issue Oct 17, 2024 · 8 comments
Open

[Bug] list view sorting by size does not work #624

heigpa opened this issue Oct 17, 2024 · 8 comments

Comments

@heigpa
Copy link

heigpa commented Oct 17, 2024

Steps to reproduce

  • Login as admin
  • Open a folder with assets
  • Change to the list view
  • Sort rows by size

Actual behaviour

  • Not possible to sort by size

Expected behaviour

  • Sorting by size should be posible

Environment

  • Nightly build
@markus-moser
Copy link
Contributor

@vin0401 We should either make it work or disable sorting by size if too complex for now. In the classic bundle its not possible to sort by size.

@vin0401
Copy link
Collaborator

vin0401 commented Nov 21, 2024

I guess, @martineiber could give us some insights here?

In the end the filtering is happening completely on the server side.
On the frontend side it should be small change so the question is, if we are able to integrate or reuse a filter in the backend bundle with a reasonable amount of effort. :P

@ValeriaMaltseva
Copy link
Contributor

@markus-moser @vin0401
JFYI: As this functionality hasn't been implemented yet, I've created the task with the Improvement label + currently on the front-end side, the field is added to the ignore list.

@markus-moser
Copy link
Contributor

@ValeriaMaltseva Thanks for the info - did you also ignore it for sorting or only for filtering?

@markus-moser
Copy link
Contributor

@vin0401 @martineiber In this case it's about sorting not about filtering. At the moment it does not work - can this be fixed on backend side?

@ValeriaMaltseva
Copy link
Contributor

@markus-moser only for filtering.

@martineiber
Copy link

@markus-moser @vin0401

I just checked this issue. It is possible to sort by File Size in the Backend. But as it seems we have a small issue with the key name. If you sort by fileSize it works. But the grid/available-columns Endpoint delivers sizeas key.

I will have a look and fix this, that the endpoint delivers the correct key.

About Filtering the file size. This is currently not possible, since we need some comparison filter with <= >=. And as far as i know we do not have any filter like this in the GDI?

@markus-moser
Copy link
Contributor

@martineiber Thanks for checking and fixing it 👍 Let's just fix the sorting and skip the filtering. We can do this in a future version - in the classic bundle we cannot filter and sort by size so it's an improvement anyways and not our top prio feature...

@martineiber martineiber self-assigned this Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants