Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context Menu #71

Open
fashxp opened this issue Mar 1, 2024 · 4 comments · Fixed by #531 or #564 · May be fixed by #609
Open

Context Menu #71

fashxp opened this issue Mar 1, 2024 · 4 comments · Fixed by #531 or #564 · May be fixed by #609
Assignees

Comments

@fashxp
Copy link
Member

fashxp commented Mar 1, 2024

  • system features like
    • add folder
    • add asset
    • rename
    • delete
    • copy, cut, paste
    • upload new version
    • locking
  • manageable via permissions
    • show/hide certain entries
    • information needs to be delivered from API
  • need to have alternative access for all features in element's toolbar more menu

image

https://www.figma.com/design/kTxowT29eCHwNh5NspDGGu/Pimcore-Components?node-id=3021-124279&t=TH6LzmPptxSxTMON-4

  • should be extendable via bundles
@markus-moser
Copy link
Contributor

markus-moser commented Jun 19, 2024

@pimcore-studio-backend-team

Please check which endpoints are missing to allow the mentioned operations.

e.g.

  • Asset deletion
  • Create folder

The upload features should be done then in a separate issue, so please consider it as out of scope for this one.

@lukmzig
Copy link

lukmzig commented Jun 25, 2024

@markus-moser could you please elaborate about concept a bit more for these 2 points?

  • manageable via permissions
    • show/hide certain entries
    • information needs to be delivered from API

what information would you need here? should it not be a part of tree endpoint?

  • need to have alternative access for all features in element's toolbar more menu
    Is there something API needs to deliver?

@markus-moser
Copy link
Contributor

@lukmzig Everything what we need regarding permissions is the permission set from the generic data index bundle which you implemented there. This needs to be part of the tree endpoint.

For the entries in the more menu we do not need something special:

  • for the copy/paste features you created already endpoints in the linked PRs
  • the lock features can be done via the regular asset update endpoint (Matthias implemented it already there)
  • Upload will be a separate issue
  • For the download we have already an endpoint, right?
  • And the "request translation" entry comes from an additional bundle (translation provider interfaces)

@lukmzig
Copy link

lukmzig commented Jun 26, 2024

Just a short summary:

permissions will be delivered via tree endpoint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment