Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Versions] Preview images for non-images #420

Open
markus-moser opened this issue Jul 18, 2024 · 6 comments
Open

[Versions] Preview images for non-images #420

markus-moser opened this issue Jul 18, 2024 · 6 comments
Assignees

Comments

@markus-moser
Copy link
Contributor

E.g. for PDFs the preview image does not work:

image

@robertSt7
Copy link
Contributor

@markus-moser How should this look like? In the old ui only the document is displayed

@markus-moser
Copy link
Contributor Author

@robertSt7 That's a good question.
We should at least add a download button to all versions independent of the type. In the old system we have something similar for all types where no preview is possible (so for all types except image and PDF):

image

As we now have a different approach we should not make a exception for images and also add the download option there. @idaiv Could you maybe please prepare a screen how a download link/button in the version preview & comparison could look like?

Is it in addition to that possible to display an image thumbnail for Asset\Document previews (so calling getImageThumbnail on the asset model)? When we display this image thumbnail the same way like for images + the download button it would be a nice approach in my opinion.

@robertSt7
Copy link
Contributor

@markus-moser unfortunately we don't have thumbnails for the Versions of Asset\Document. We can't implement this at the moment

@markus-moser
Copy link
Contributor Author

@robertSt7 Then let's just add the download button for the moment

@idaiv
Copy link

idaiv commented Aug 23, 2024

Hi Markus! Sorry for the delay on this task. The design is approved and ready for implementation.

Link: https://www.figma.com/design/kTxowT29eCHwNh5NspDGGu/Pimcore-Components?node-id=5459-218562&t=XuuBIvPJ6ynSxhl2-4

@markus-moser
Copy link
Contributor Author

Hi Ida,
nice, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants