Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Grid Functionality #206

Merged
merged 23 commits into from
Jul 2, 2024
Merged

[Feature] Grid Functionality #206

merged 23 commits into from
Jul 2, 2024

Conversation

mattamon
Copy link
Contributor

@mattamon mattamon commented Jul 1, 2024 •
edited
Loading

Changes in this pull request

Partially resolves pimcore/studio-ui-bundle#175

@mattamon mattamon marked this pull request as draft July 1, 2024 12:27
@mattamon mattamon marked this pull request as ready for review July 2, 2024 12:57
@mattamon mattamon requested a review from martineiber July 2, 2024 12:57
martineiber
martineiber requested changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@martineiber martineiber left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor Questions :) Rest LGTM 👍

src/Grid/Column/ColumnDefinitionInterface.php Outdated Show resolved Hide resolved
src/Grid/Column/ColumnDefinitionInterface.php Outdated Show resolved Hide resolved
src/Grid/Column/Resolver/DatetimeResolver.php Show resolved Hide resolved
src/Grid/Column/Resolver/FileSizeResolver.php Outdated Show resolved Hide resolved
src/Grid/Util/Trait/SimpleGetterTrait.php Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
12 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

martineiber
martineiber approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@martineiber martineiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mattamon mattamon merged commit ebc72fe into 1.x Jul 2, 2024
12 checks passed
@mattamon mattamon deleted the grid-config branch July 2, 2024 13:57
@github-actions github-actions bot locked and limited conversation to collaborators Jul 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@martineiber martineiber martineiber approved these changes

Assignees

@martineiber martineiber

@mattamon mattamon

Labels
New Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Asset List Grid Config
2 participants
@mattamon @martineiber