-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Data Object Editor] Use same format for manyToManyObjectRelation like for manyToManyRelation #706
Comments
Hey @markus-moser, there is an open pr for the adapters. #701 Bear in mind, that set for patch/update were adapted to work with the get adapters data. It would help a lot if we would have the structure before. Otherwise this results in unecessary rework everytime where we stray from the core normalizer. |
@mattamon Yes I agree that this could help, but please keep in mind that I also need to analyze all data types step by step in detail to be able to implement it in the frontend. ;) As we only have a few data types left it shouldn't be a big problem. But feel free to analyze the main missing data types (advanced many to many object relation and reverse object relation) and adjust it to a suitable format. |
And also you can see in your linked PR the adapter for this data type isn't implemented yet, so no rework needed :) |
We have all adapters implemented already .... we already had to adapt some which are included in the PR and with every change request we need to adapt more a re-test them including containers. That would be unnecessary if you would provide us format in which you need the data .... |
Yes but we discussed initially that we do the adapters step by step while we implement it in the frontend. It's impossible/inefficient for my work to provide all formats of all adapters upfront. |
@markus-moser relation adapters responses were adapter here: #710 |
Nice, thanks a lot |
Currently it looks like this:
But it should be the same format and logic like for the many to many relation:
For sure it's ok when we use "object" instead of "data-object" as discussed with @lukmzig.
The text was updated successfully, but these errors were encountered: