-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improvement]: Define DataObject table datatype more clear #879
Comments
Hi, not sure I can follow you. Can you please elaborate a bit more or provide a more specific example. Thx |
@fashxp , so, based on changes datatype name looks like: |
I see ... would that be a BC break? As it changes the type name? |
@fashxp , not sure about BC break. Firstly, previous class name looks like more generic and no idea how it's used now - after applying fix it'll be clear. Secondly, Changes aren't update fields - that more critical for as BC. And last but not least, As I see you've couple the same PRs and issues with likely looks with type names changes (Ex. PR #876) as it's not BC. Ofc, as suggestion, include these changes to next coming release 1.8.0 - it'll be easier track dependency of might be some potential changes that linked with using old/new field type name. |
@vmalyk I'm looking at it from API consumer perspective and just asking 😄. |
#876 is somehow different, as it seems that the type name changes on every request anyway... |
@fashxp, but it's only 1 way how to clarify field types that important for API consumers and tracking that should be easier as it's present now - and it's 1 way by type name. |
I'm not against the change, just wanted to clarify! |
Improvement description
For some cases table and structure table require specific handling, but no way to clarify that , because in generated typename - it contains parent type (object,field collection), class name, fieldname.
As suggestion, If adding additionally field type - it'll be helpful for improve field handling on integration side.
The text was updated successfully, but these errors were encountered: