Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement]: Define DataObject table datatype more clear #879

Open
vmalyk opened this issue Sep 16, 2024 · 8 comments
Open

[Improvement]: Define DataObject table datatype more clear #879

vmalyk opened this issue Sep 16, 2024 · 8 comments

Comments

@vmalyk
Copy link
Contributor

vmalyk commented Sep 16, 2024

Improvement description

For some cases table and structure table require specific handling, but no way to clarify that , because in generated typename - it contains parent type (object,field collection), class name, fieldname.
As suggestion, If adding additionally field type - it'll be helpful for improve field handling on integration side.

@fashxp
Copy link
Member

fashxp commented Sep 16, 2024

Hi, not sure I can follow you. Can you please elaborate a bit more or provide a more specific example. Thx

@vmalyk
Copy link
Contributor Author

vmalyk commented Sep 16, 2024

@fashxp , so, based on changes datatype name looks like:
Screenshot 2024-09-16 at 10 59 38

@fashxp
Copy link
Member

fashxp commented Sep 17, 2024

I see ... would that be a BC break? As it changes the type name?

@vmalyk
Copy link
Contributor Author

vmalyk commented Sep 18, 2024

@fashxp , not sure about BC break. Firstly, previous class name looks like more generic and no idea how it's used now - after applying fix it'll be clear. Secondly, Changes aren't update fields - that more critical for as BC. And last but not least, As I see you've couple the same PRs and issues with likely looks with type names changes (Ex. PR #876) as it's not BC.

Ofc, as suggestion, include these changes to next coming release 1.8.0 - it'll be easier track dependency of might be some potential changes that linked with using old/new field type name.

@fashxp
Copy link
Member

fashxp commented Sep 19, 2024

@vmalyk I'm looking at it from API consumer perspective and just asking 😄.
I'm just wondering, if the type name is part of some GraphQL query ... which might not work afterwards anymore since the name changed.
Of if someone generated an API SDK based on the graphql schema...might that be a problem when the type name changes?

@fashxp
Copy link
Member

fashxp commented Sep 19, 2024

#876 is somehow different, as it seems that the type name changes on every request anyway...

@vmalyk
Copy link
Contributor Author

vmalyk commented Sep 26, 2024

@fashxp, but it's only 1 way how to clarify field types that important for API consumers and tracking that should be easier as it's present now - and it's 1 way by type name.
How about another approach and adding interface to type with additional fields - cols and rows - will it helps clarify field type and might be helpful for processing data on client side ?
in this case, it won't be BC regarding type and current fields, but it'll be add more ways for manipulate data on "client" side?

@fashxp
Copy link
Member

fashxp commented Sep 26, 2024

I'm not against the change, just wanted to clarify!
Because when we agree to do it that way, we need to label it as be break, add an upgrade note and wait for the next major - which we eventually could to starting next year...

@fashxp fashxp added this to the 2.0.0 milestone Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants