Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support fzf-lua as a folder picker #15

Closed
parisni opened this issue Dec 19, 2024 · 1 comment · Fixed by #17
Closed

Support fzf-lua as a folder picker #15

parisni opened this issue Dec 19, 2024 · 1 comment · Fixed by #17
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@parisni
Copy link
Contributor

parisni commented Dec 19, 2024

Hey, I am using ibhagwan/fzf-lua instead of junegunn/fzf.vim. Sounds like it does not works the same ?

after setting:

let g:himalaya_folder_picker = 'fzf'

I get the bellow error:

Error detected while processing function <lambda>71[1]..<SNR>39_on_exit[9]..<lambda>68[1]..<SNR>36_on_json_data[1]..<lambda>67[1]..<SNR>35_op
en_picker[13]..himalaya#domain#folder#pickers#fzf#select:
line    1:
E117: Unknown function: fzf#run

thanks for your insights
@parisni parisni changed the title fzf.nvim likely not working as a picker fzf.lua likely not working as a picker Dec 19, 2024
@soywod
Copy link
Member

soywod commented Dec 19, 2024

Hey, indeed the fzf backend expects junegunn/fzf.vim. Feel free to propose a PR in order to support fzf-lua.

@soywod soywod changed the title fzf.lua likely not working as a picker Support fzf-lua as a folder picker Dec 19, 2024
@soywod soywod added enhancement New feature or request help wanted Extra attention is needed labels Dec 19, 2024
@soywod soywod added this to Pimalaya Dec 19, 2024
@parisni parisni mentioned this issue Dec 21, 2024
Merged
@github-project-automation github-project-automation bot moved this to Done in Pimalaya Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
Pimalaya
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support fzf-lua as a folder picker parisni/himalaya-vim
2 participants
@parisni @soywod