Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gpg packages need to be installed despite pgp feature not enabled #23

Closed
djmaze opened this issue Sep 30, 2024 · 4 comments
Closed

gpg packages need to be installed despite pgp feature not enabled #23

djmaze opened this issue Sep 30, 2024 · 4 comments
Labels
duplicate This issue or pull request already exists

Comments

@djmaze
Copy link
Contributor

djmaze commented Sep 30, 2024

Just tried to compile my app against the latest master (on NixOS). Had to gnupg and gpgme although I do not have pgp-* features enabled in my Cargo.toml.

@djmaze djmaze changed the title gpg packages need to be installed despite gpg feature not enabled gpg packages need to be installed despite pgp feature not enabled Sep 30, 2024
@soywod
Copy link
Member

soywod commented Sep 30, 2024

  • The flake.nix from the current repository does not link Cargo features with Nix, this could definitely be a nice improvement.
  • That said, the current version on nixpkgs does the link, could you share your Nix code?

I would advise not to use actual versions on repositories because they are not up-to-date (due to the beta). The v1.0.0 is being tested on master, which I would recommand to use instead.

@soywod soywod added the question Further information is requested label Sep 30, 2024
@soywod soywod added this to Pimalaya Sep 30, 2024
@djmaze
Copy link
Contributor Author

djmaze commented Oct 8, 2024

I am building my own app which uses the email-lib crate (latest master) with a custom (non-flake) shell.nix. But I think it does matter. I just want to propose that it should be possible to use the email-lib crate without the gpg dependencies, as the pgp-* features are already optional in the codebase.

@soywod
Copy link
Member

soywod commented Oct 9, 2024

I just want to propose that it should be possible to use the email-lib crate without the gpg dependencies, as the pgp-* features are already optional in the codebase

Yes I agree, I just have no idea how to do with nix flakes. Last time I searched, it was not possible to pass arguments to the nix build.

@soywod soywod moved this to Todo in Pimalaya Oct 9, 2024
@soywod soywod added bug Something isn't working and removed question Further information is requested labels Oct 9, 2024
@soywod
Copy link
Member

soywod commented Oct 9, 2024

Duplicate #22.

@soywod soywod closed this as not planned Won't fix, can't repro, duplicate, stale Oct 9, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Pimalaya Oct 9, 2024
@soywod soywod moved this from Done to Cancelled in Pimalaya Oct 9, 2024
@soywod soywod removed this from Pimalaya Oct 9, 2024
@soywod soywod added duplicate This issue or pull request already exists and removed bug Something isn't working labels Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants