Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing files ? "buildGLM.buildModel" "fitGLM" and more ? #16

Open
adehad opened this issue Oct 29, 2020 · 1 comment
Open

Missing files ? "buildGLM.buildModel" "fitGLM" and more ? #16

adehad opened this issue Oct 29, 2020 · 1 comment

Comments

@adehad
Copy link

adehad commented Oct 29, 2020

Have unsuccessfully tried to run tutorial.m, seemingly because it is unclear what fitGLM and buildGLM.buildModel resolve to.

Initial Point of Failure

neuroGLM/tutorial.m

Lines 120 to 130 in e603491

%{
%% Specify the model
hasBias = true;
model = buildGLM.buildModel(dspec, 'Poisson', 'exp', hasBias);
%% Do regression
[w, stats] = fitGLM(model, dm, y);
%}
%% Visualize fit
visualizeFit(w, model, dspec, vparam(1)); % ???

Line 130 references an unresolved model variable that seems to be set in the previously commented L121-L126.

Uncommenting the commented lines is also funky:

  1. buildGLM.buildModel does not exist
  2. fitGLM I assume should exist under buildGLM but it does not. Currently it conflicts with Matlab's inbuilt fitglm

Giving a quick look through the available source in this repo neuroGLM\matRegress\+glms\autoFitGLM.m is the closest to actually returning a model, but does not seem to match the function call in L130?

function model = autoFitGLM(X,Y, prspec, varargin)

Likely Further Points of Failures

neuroGLM/tutorial.m

Lines 136 to 141 in e603491

yPred = generatePrediction(w, model, dmTest);
ySamp = simulateModel(w, model, dmTest);
%% Validate model
gof = goodnessOfFit(w, stats, model, dmTest);
visualizeGoodnessOfFit(gof);

Afterwards I imagine generatePrediction, simulateModel, goodnessOfFit, visualizeGoodnessOfFit would also be unresolved as I cannot find anything with those names in the repo.


Am I missing something obvious? The docs/tutorial.md does seem to suggest another approach using the dm matrix that I can explore further, but I was expecting the tutorial to work in the first instance regardless.

neuroGLM/docs/tutorial.md

Lines 185 to 186 in e603491

# Regression analysis
Once you have designed your features, and obtained the design matrix, it's finally time to do some analysis!

@haileygordon
Copy link

Also curious about this inquiry above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants