Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promise support for router.param #91

Closed
jonchurch opened this issue Apr 17, 2020 · 4 comments
Closed

Promise support for router.param #91

jonchurch opened this issue Apr 17, 2020 · 4 comments
Assignees
@jonchurch
Labels
enhancement express-v5

Comments

@jonchurch
Copy link
Member

jonchurch commented Apr 17, 2020 •
edited
Loading

This is a reminder to myself (or anyone else) to implement this and give a smooth upgrade path to users of express-async-errors

davidbanham/express-async-errors#28
@jonchurch
Copy link
Member Author

@dougwilson Can you assign this issue to me? I don't seem to have perms to do that in this repo.

@jonchurch jonchurch mentioned this issue Apr 19, 2020
Merged
dougwilson pushed a commit to jonchurch/router that referenced this issue Dec 10, 2021
@jonchurch @dougwilson
Add support for returned, rejected Promises to router.param
83dc504 
closes pillarjs#91
closes pillarjs#92
@wesleytodd
Copy link
Member

@jonchurch are you still interested in working on this? If you are, I would love to figure out how we can land holistic promise support before router@2 happens. I have this one in flight from a while back as well: #75

@jonchurch
Copy link
Member Author

jonchurch commented Mar 16, 2024 •
edited
Loading

Yeah Im interested. Need to dig up old stuff from the past but I had reached out to the maintainer of a popular package that monkey patched router with promise support.

If I can coordinate a release there to not crash when people use it with a native promise supporting router that would be great

@jonchurch
Copy link
Member Author

jonchurch commented Mar 17, 2024 •
edited
Loading

@wesleytodd oh this merged but the issue wasn't closed #92

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonchurch jonchurch

Labels
enhancement express-v5
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wesleytodd @jonchurch