Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Why hardcoded HTTPS for some providers? #200

Open
asitanc opened this issue Nov 11, 2024 · 3 comments
Open

[Question] Why hardcoded HTTPS for some providers? #200

asitanc opened this issue Nov 11, 2024 · 3 comments
Labels

Comments

@asitanc
Copy link
Contributor

asitanc commented Nov 11, 2024

Description

In the v2 release of Arctic, the Authentik provider has hardcoded the https:// protocol in the constructor:

constructor(domain: string, clientId: string, clientSecret: string, redirectURI: string) {
this.authorizationEndpoint = `https://${domain}/application/o/authorize/`;
this.tokenEndpoint = `https://${domain}/application/o/token/`;
this.tokenRevocationEndpoint = `https://${domain}/application/o/revoke`;

This implementation causes two main issues:

  • It restricts users to only use HTTPS
  • It complicates local development environments where HTTP might be preferred.

Question

  • What was the rationale behind introducing this change?
  • Why does the Authentik provider use a hardcoded HTTPS protocol, while other providers (e.g., Keycloak, which is a selfhosted alternative) don't have this restriction?

Please, consider making the protocol configurable, allowing users to specify either HTTP or HTTPS based on their requirements.

@pilcrowonpaper
Copy link
Owner

This was done for consistency sake, but honestly better if we update all domain parameters to baseURL

@pilcrowonpaper
Copy link
Owner

Unfortunately this will be a breaking change so it has to be part of v3

@pilcrowonpaper
Copy link
Owner

Related to #190

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants