Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strava provider work wrong #183

Open
SxYxuse opened this issue Oct 25, 2024 · 1 comment
Open

Strava provider work wrong #183

SxYxuse opened this issue Oct 25, 2024 · 1 comment

Comments

@SxYxuse
Copy link

SxYxuse commented Oct 25, 2024

Hi,

The first small fix to do it's in the doc -> you should pass the refreshToken instead of accessToken in the refresh method
Screenshot 2024-10-25 at 19 37 16

Then when the authorization url is created the scopes should have a , between them instead of spacing. Because currently everytime we redirect to the Strava Promp we need to grant access instead of doing it automatically.

Must look like this : scopes=activity:read_all,read
Screenshot 2024-10-25 at 19 38 15

Thanks

@pilcrowonpaper
Copy link
Owner

Fixed the typo. Looks like all the providers' doc had that issue.

As for scopes, that's not compliant with the spec so we'd probably want to remove the scope parameter. We don't follow semver so I could just remove it in the next minor release, but it technically "works" so I'm not sure yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants