Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GDPuc is not registering with madrat, therefore does not affect caching #573

Open
0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q opened this issue Oct 11, 2024 · 1 comment · May be fixed by #574
Open

GDPuc is not registering with madrat, therefore does not affect caching #573

0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q opened this issue Oct 11, 2024 · 1 comment · May be fixed by #574
Assignees
@fbenke-pik
Labels
bug Something isn't working

Comments

@0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q
Copy link
Member

Which is bad, since pik-piam/GDPuc#37 is transparent to madrat, which happily loads everything calculated using faulty dollar conversion factors from the cache.
@0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q 0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q added the bug Something isn't working label Oct 11, 2024
@0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q 0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q linked a pull request Oct 11, 2024 that will close this issue
Open
@0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q
Copy link
Member Author

#574 fixes this for mrremind. But this is an endemic issue across the "madrat-verse"

$ reposearch -l 'convertGDP' | grep 'pik-piam/mr.*R$' | sort
repos/pik-piam/mrcommons/master/R/calcGTAPTotalTransportCosts.R
repos/pik-piam/mrcommons/master/R/calcIniFoodPrice.R
repos/pik-piam/mrcommons/master/R/calcMAgPIEReport.R
repos/pik-piam/mrcommons/master/R/calcPriceAgriculture.R
repos/pik-piam/mrcommons/master/R/calcWBGEM.R
repos/pik-piam/mrcommons/master/R/convertGTAPv8v9.R
repos/pik-piam/mrcommons/master/R/convertICP2017.R
repos/pik-piam/mrcommons/master/R/convertSSPResults.R
repos/pik-piam/mrcommons/master/R/readIMPACT3.2.2World_Price.R
repos/pik-piam/mrdrivers/main/R/calcGDPFuture.R
repos/pik-piam/mrdrivers/main/R/calcGDPPast.R
repos/pik-piam/mrdrivers/main/R/calcGDPpc.R
repos/pik-piam/mrdrivers/main/R/calcGDP.R
repos/pik-piam/mrdrivers/main/R/readEurostatPopGDP.R
repos/pik-piam/mrfactors/main/R/calcFactorCostsCrops.R
repos/pik-piam/mrfactors/main/R/calcFactorCostsLivst.R
repos/pik-piam/mrfactors/main/R/calcFactorIntensity.R
repos/pik-piam/mrfactors/main/R/calcHourlyLaborCosts.R
repos/pik-piam/mrfactors/main/R/calcLaborCosts.R
repos/pik-piam/mrfactors/main/R/calcPricesProducer.R
repos/pik-piam/mrfactors/main/R/calcProductionCosts.R
repos/pik-piam/mrfactors/main/R/calcVoPAFF.R
repos/pik-piam/mrfactors/main/R/calcVoPcrops.R
repos/pik-piam/mrfactors/main/R/calcVoPlivst.R
repos/pik-piam/mrfactors/main/R/convertIFPRIsubsidy.R
repos/pik-piam/mrfactors/main/R/convertILOSTAT.R
repos/pik-piam/mrfactors/main/R/convertVittis.R
repos/pik-piam/mrfaocore/main/R/convertFAO_online.R
repos/pik-piam/mrfaocore/main/R/convertFAOTradeMatrix.R
repos/pik-piam/mrland/master/R/calcGDPdeflator.R
repos/pik-piam/mrland/master/R/calcIrrigationInvCosts.R
repos/pik-piam/mrland/master/R/calcTradeMargin.R
repos/pik-piam/mrland/master/R/calcTradeTariff.R
repos/pik-piam/mrland/master/R/convertSathayeForest.R
repos/pik-piam/mrremind/master/R/calcBiomassPrices.R
repos/pik-piam/mrremind/master/R/calcBP.R
repos/pik-piam/mrremind/master/R/calcCO2Prices.R
repos/pik-piam/mrremind/master/R/calcCostsTradePeFinancial.R
repos/pik-piam/mrremind/master/R/calcCostsWeathering.R
repos/pik-piam/mrremind/master/R/calcDiffInvestCosts.R
repos/pik-piam/mrremind/master/R/calcEconometricEmiParameter.R
repos/pik-piam/mrremind/master/R/calcEU_ReferenceScenario.R
repos/pik-piam/mrremind/master/R/calcIndustry_EEK.R
repos/pik-piam/mrremind/master/R/calcINNOPATHS.R
repos/pik-piam/mrremind/master/R/calcJRC_IDEES.R
repos/pik-piam/mrremind/master/R/calcTaxConvergence.R
repos/pik-piam/mrremind/master/R/calcTaxLimits.R
repos/pik-piam/mrremind/master/R/calcTaxXport.R
repos/pik-piam/mrremind/master/R/convertDylanAusGasCost.R
repos/pik-piam/mrremind/master/R/convertGEA2012.R
repos/pik-piam/mrremind/master/R/convertIIASA_subs_taxes.R
repos/pik-piam/mrremind/master/R/convertTransportSubisidies.R
repos/pik-piam/mrremind/master/R/EDGE-Industry.R
repos/pik-piam/mrremind/master/R/UNIDO.R
repos/pik-piam/mrtransport/main/R/convertPSI.R
repos/pik-piam/mrtransport/main/R/convertUCD.R
repos/pik-piam/mrvalidation/master/R/calcValidAgFFGDP.R
repos/pik-piam/mrvalidation/master/R/convertIMPACTIrrigInvCosts.R
repos/pik-piam/mrvalidation/master/R/readPardeyAgRD.R

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fbenke-pik fbenke-pik

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

explicitly monitor GDPuc::convertGDP for madrat caching 0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q/mrremind
2 participants
@0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q @fbenke-pik