Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Swiping a light down to the lowest brightness turns it off #847

Open
2 tasks done
wilco375 opened this issue Nov 12, 2022 · 2 comments · May be fixed by #848
Open
2 tasks done

[Bug]: Swiping a light down to the lowest brightness turns it off #847

wilco375 opened this issue Nov 12, 2022 · 2 comments · May be fixed by #848
Labels
bug Something isn't working

Comments

@wilco375
Copy link

wilco375 commented Nov 12, 2022 •
edited
Loading

Requirements

  • I have updated Mushroom to the latest available version
  • I did a search to see if there is a similar issue.

Current Behavior

When using the light card and using the brightness slider, there is no easy way to set the light to the lowest brightness. Swiping the brightness all the way to the left (to 0%) turns the light off, which can already be accomplished by simply clicking the card.

Expected Behavior

Swiping the brightness down sets the brightness to 1%, and does not turn off the light.

Steps To Reproduce

  1. Create a light card with brightness control
  2. Turn the light on
  3. Swipe down the brightness all the way to the left

Context

No response

Environment

- Browser: Firefox
- HA Version: 2022.11.2
- Mushroom: 2.3.6

Anything else?

No response
@wilco375 wilco375 added the bug Something isn't working label Nov 12, 2022
@wilco375 wilco375 linked a pull request Nov 12, 2022 that will close this issue
Open
9 tasks
@antonio1475
Copy link

Thank you for the PR 848. This topic was mentioned in #733 (comment)

I fear that it won't get merged if it's not an option as you mentioned in the PR, since it would change the behaviour for all users that might be used to swiping down to 0...

Stupid question: shouldn't I be able to add .min=${1} to /config/www/community/lovelace-mushroom/mushroom.js line 2370 (and delete mushroom.js.gz) and make it work? It doesn't.

How does your mushroom.js look like? I'm trying to achieve this without rebuilding mushroom... 😅

@antonio1475
Copy link

antonio1475 commented Nov 17, 2022 •
edited
Loading

I got it now.

  1. I removed Mushroom from HACS
  2. Followed the Mushroom manual installation instructions instead, but before uploading the mushroom.js file I added line 2370 with .min=${1}
    I suppose it could be modified after uploading it, but this way no refreshes are needed. It works!

I don't really understand the difference to HACS installation as the HACS Mushroom folder had so many files and .gz, while manual is just one file that also existed in the HACS folder, but it works so good for now. (other than needing to manually update of course, but I'm subscribed/notified so no problem)

Thank you @wilco375 !!
Looking forward to PR 848 but as piitaya mentioned, it's not so straightforward... 😅

@piitaya piitaya mentioned this issue Dec 1, 2022
Closed
3 tasks
@Snellingen Snellingen mentioned this issue Dec 14, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set min light brightness to 1 wilco375/lovelace-mushroom
2 participants
@wilco375 @antonio1475