Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#80 add license page to nimibook #86

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

PhilippMDoerner
Copy link
Contributor

As per #80 this adds the suggested page from the nimibook.

Note: I did basically 0 research for this. I read the issue and copy pasted the list from can.l + added KaTeX since it was mentioned during the issue.

If anything else needs adding, please say so.

The majority of the work here was done by Can.L either way ^^

@pietroppeter
Copy link
Owner

Thanks! I just realized from reading this that we should probably add also mention of mdbook (MIT license IIRC). I can just add it later along with the license module.

@PhilippMDoerner
Copy link
Contributor Author

Alrighty, happy to be a catalyst 😄

@pietroppeter pietroppeter merged commit b68c33d into pietroppeter:main Oct 23, 2023
5 checks passed
@PhilippMDoerner PhilippMDoerner deleted the add-licenses branch October 23, 2023 17:40
@pietroppeter
Copy link
Owner

Thanks for this, looks good! merging and will add a note to the issue about the missing pieces

@pietroppeter
Copy link
Owner

we should probably add also mention of mdbook (MIT license IIRC)

on second thoughts I do not think we need to add mdbook license since mdbook is not part of nimibook but mdbook code has been used (and adapted) in nimibook. A number of license we add are indeed from mdbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants