-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rfc] refactor bookcfg #17
Conversation
IMO Therefore, |
agree, this is covered by this PR ( |
Just before I went to sleep I thought of a similar situation, I'm glad you were able to implement it a lot faster than me haha. import nimib, nimibook / defaults
## Initializes a nimib document with nimibooks defaults and other stuff about what prelude.nim might do
nbInit
nbDoc.useNimibook And in Of course if this is just a temporary thing then I think things are just fine as is. |
Looks good to me. |
Glad you managed the circular deps. This looks good to me as well :) |
thanks all! I will incorporate the suggestions of @zetashift and will merge later this evening. I was also planning to make a submission for this project in "This Month in Nim" for the month of May (to support the initiative and give visibility) and my idea was to mention you all as contributors in the description (whatever the state of commits, discussing, using, reporting issues is definitely contributions). I will update you when I have prepared a draft of the submission. the idea is also this weekend for me is to work on issues #10, #9 so that the repo is in a presentable state when people give a look at it. |
@pietroppeter sounds like a great idea! 😄 The more people who are aware of the greatness of Nimib and NimiBook the better! Would be an honor to be mentioned as a contributor 🤯 Didn't even notice that hidden comment 🙃 Feels like we have come a long way in fixing the most essential of those features at least. I mean except from choosing the default theme + next/prev buttons + search there isn't that much in there that is specific to NimiBook (ie should be in Nimib). Except adding in some Nimib links of course :) Next month maybe we could submit SciNim/getting-started to prolong the exposure of NimiBook even more 😮 |
That is a great idea
#12 Needs to be solved. First thing people will try is creating a book and currently there is no "proper" solution to do that.
For now getting-started is empty. We should probably aim to write some content before advertising it 😆 |
For now, the template functionality would suffice? Or just cloning the repo if one would want to do it locally without involving a Github repo. But a nice executable would be optimal of course 🤔 And how are we going to migrate to NimiBook from what we currently have? An executable wouldn't have made it easier to transfer though. Yesterday when working on NimiBoost I removed all code from the the repo and copy-pasted in a newly generated Extension-template so it does work which in a pinch at least 😝
We have entire month to write content, that's lots of time... 🤣 |
added a
@zetashift I will add those when working on #10 |
nimibook / prelude
that initializes a nimib document with nimibook defaults. it is something that you would include at beginning of document (similar toinclude karax / prelude
but it does a bit more since it also initializes the nimib document)since I made a few changes recently without discussing much, I keep this PR open for comments of contributors. @Clonkk, @HugoGranstrom, @zetashift, let me know what you think, feel free also to rediscuss/criticize previous changes about bookcfg.